Rullst AcademyRullst Academy/Lesson
Git: changes as a team · Lesson 05 / 10

Review with evidence and care

Review improves a change without treating a person as the problem.

Learning paths16 min

Let's discover together

  1. 1

    In reviewer, fetch and create review-fix from origin/fix-boundary as LAB.md shows. Read the requirement before the diff. Check origin, files and hash; do not run unknown code with access to real data. These small files are supplied for study.

  2. 2

    A useful comment connects observation and consequence: “With >= 120, input 120 is rejected although the agreement accepts it. Could we add that test and use > 120?” It offers a checkable action. “Your code is bad” neither explains nor helps fix it.

  3. 3

    Separate blockers, questions and preferences. A behavior defect can block; a question requests context; style outside the agreement may be optional. GitHub reviews support comments, approval and change requests; repository rules determine their merge effects.

  4. 4

    Run tests and inspect what they miss. Three green tests using only 15 do not show that 120 works. Record the reviewed hash, commands, outcome and limits in REVIEW.md. The final workshop practices decisions on fictional diffs without sending comments to anyone.

One change, two roles

Download the kit and follow LAB.md in a new folder. Commands here are reading references; the site does not execute them. Use Git Bash on Windows and a terminal on macOS/Ubuntu. Earlier tracks cover Git and Python setup.

git fetch origin
git switch -c review-fix origin/fix-boundary
python -m unittest discover -v
My files and GitHub

Edit, download and send your Markdown notebook to GitHub with confirmation. It does not run Git or open pull requests. The kit is the starter; save edits separately.

Official links and next step

✦
YOUR MISSION

Connect a comment to a requirement, test and concrete risk.

Now it's your turn

Discovery workshop

A decision with evidence

The diff changes > 120 to >= 120. Old tests stay green but never test 120.
Build your answers and check when you are ready.
A moment to understand

Which review is supported?

I need a hint

Compare the agreement with the diff and evidence for the current commit.

Loading your journey…

Take it with you

Write a blocker, a question and an optional suggestion about the proposal, identifying evidence for each.

At your own pace

My files and GitHub

Every lesson can become your own record: code, notes or a practice plan. Saving a file to GitHub is optional and does not change your XP.

Student guide

The editor and downloads open when this lesson is available to your account. Check access below or return to the track map.

Checking your access to this lesson…

Rullstpetbot

AI can make mistakes. Check the lesson material.